DWI models: Define "bvec" orientation reference #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FSL bedpostx command fibre orientations stored as spherical coordinates are confirmed to use the "bvec" reference frame. - Enforcing azimuth angle to obey the right hand rule about the zenith axis would necessitate direct modification of image intensities from bedpostx outputs to store. Therefore it would be preferable to instead define the sign of the azimuth angle based on the direction of the second reference axis. Closes #95. Closes #94.
|
I think this is ready to go, right? Could you take a look/resolve the conflicts? I just updated the bep-16 branch with a merge from bids-standard/bids-specification:master |
Conflicts: src/derivatives/05-diffusion-derivatives.md
|
I'm not 100% happy with the description of the azimuth angle. I wonder if it needs to be explicit about the trigonometric relationships involved in either direction. Another prospect to consider would be tailored figures showing the interpretations of coefficients relative to any arbitrary reference frame. But it's good enough, so I'll merge and if a better idea comes across anyone we can revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #94.
While I have not yet completed all of the relevant work, I have at least convinced myself of the fact that the eigenvector images produced by FSL's
dtifitare not defined with respect to the image axes; rather, they use the same convention as thebvecsformat. Therefore, to be able to write such data to a BIDS-compliant dataset without image intensity modification, that coordinate system needs to be included in the specification.While I suspect the
bedpostxoutputs use the same convention, I've not yet confirmed that for #94, so I'm deferring that for now.